I am sure a compromise can be reached between yourself and MrPablo to integrate the proposed changes into the latest version; as it does make sense, the case you are putting forward....
From what I understand personally, the charging logic implementation is pretty much information complete.
There is not much that we have changed in the charging logic in the last two months.
The project has moved on to tackling the multi-bms problem instead.
The AutoCVL features are really just protections measures to prevent Cell OVP alarms in very unbalanced packs.
Where we are actually experiencing issues currently is regarding how BMS's handle cell balancing and how to ensure convergent cell balancing. And that requires the charging logic to dictate when balancing takes place.
Unfortunately, this is something that is not in our hands. Unless, JK decide to roll out a firmware update that is.
This is really the hurdle we are facing in order to release a truly, plug, play, configure once and forget system.
On the plus side,
The hard working guys have already managed to push changes to the current dev branch. The code has now been nicely separated into modules. Needless to say, the charging logic has also been separated. My recommendation is to start from there.
All in all, It is easier now to maintain a separate charging implementation if so desired.
I fail to see the need personally, but at the same time, feel free to tweak things. It is Open Source after all.
again hard to tell with my limited coding knowledge
Coding knowledge is not a necessity in order to contribute to the project. Fundamental and experimentally rooted understanding is of primary importance. You can not be a coder and still contribute with feature suggestions, bugs squashing, testing, wiki/documentation/video/tutorials and much more.